Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecs_ecr - remove deprecated delete_policy option #1161

Merged
merged 1 commit into from
May 26, 2022
Merged

ecs_ecr - remove deprecated delete_policy option #1161

merged 1 commit into from
May 26, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 25, 2022

SUMMARY

Remove the deprecated delete_policy option.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ecs_ecr

ADDITIONAL INFORMATION

See also: ansible/ansible#48997

@ansibullbot
Copy link

cc @jillr @leedm777 @markuman @s-hertel
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels May 25, 2022
@github-actions
Copy link

github-actions bot commented May 25, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-galaxy-importer FAILURE in 4m 19s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 53s
❌ ansible-test-sanity-docker-devel RETRY_LIMIT in 7m 58s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 11m 50s
❌ ansible-test-sanity-docker-stable-2.9 FAILURE in 13m 44s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 10m 10s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 11m 44s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 22s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 7m 02s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble
Copy link
Contributor Author

tremble commented May 25, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

❌ ansible-galaxy-importer FAILURE in 4m 26s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 04s
❌ ansible-test-sanity-docker-devel FAILURE in 10m 07s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 10m 41s
❌ ansible-test-sanity-docker-stable-2.9 FAILURE in 12m 32s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 10m 42s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 11m 38s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 04s
✔️ ansible-test-splitter SUCCESS in 2m 49s
✔️ integration-community.aws-1 SUCCESS in 6m 50s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble force-pushed the deprecation/4.0.0/ecs_ecr branch from 60420c4 to 38c17a3 Compare May 25, 2022 19:49
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 3m 52s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 50s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 18s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 06s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 32s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 10s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 43s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 46s
✔️ ansible-test-splitter SUCCESS in 2m 26s
✔️ integration-community.aws-1 SUCCESS in 6m 25s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label May 25, 2022
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 4m 54s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 26s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 43s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 10s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 05s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 51s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 18s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 7m 38s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit fbb33ee into ansible-collections:main May 26, 2022
@renovate renovate bot mentioned this pull request Jun 24, 2022
Merged
1 task
@tremble tremble deleted the deprecation/4.0.0/ecs_ecr branch July 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @markuman